maskit commented on code in PR #12885:
URL: https://github.com/apache/trafficserver/pull/12885#discussion_r2814557131
##########
src/proxy/logging/LogField.cc:
##########
@@ -474,6 +476,9 @@ LogField::marshal_len(LogAccess *lad)
case MSDMS:
return lad->marshal_milestone_diff(m_milestone1, m_milestone2, nullptr);
+ case MSTSMS:
+ return lad->marshal_milestones_csv(nullptr);
Review Comment:
Do we need this addition? It looks like we need to add a case only if the
log field supports the format like these.
> %<{Milestone field name}ms>
%<{Milestone field name1-Milestone field name2}msdms>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
