maskit commented on code in PR #12885:
URL: https://github.com/apache/trafficserver/pull/12885#discussion_r2824318184
##########
src/proxy/logging/LogField.cc:
##########
@@ -556,6 +558,9 @@ LogField::marshal(LogAccess *lad, char *buf)
case MSDMS:
return lad->marshal_milestone_diff(m_milestone1, m_milestone2, buf);
+ case MSTSMS:
+ return lad->marshal_milestones_csv(buf);
Review Comment:
Same as the other switch-case. This line won't be run. The marshal function
is already set when you create a `LogField` object, and it should be called at
the beginning of this function.
> if (m_container == NO_CONTAINER) {
return (lad->*m_marshal_func)(buf);
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
