serrislew commented on code in PR #12880:
URL: https://github.com/apache/trafficserver/pull/12880#discussion_r2814608901
##########
src/iocore/hostdb/HostDB.cc:
##########
@@ -1324,7 +1324,9 @@ HostDBRecord::select_best_http(ts_time now, ts_seconds
fail_window, sockaddr con
}
}
} else {
- best_alive = &info[0];
+ if (!info[0].is_down(now, fail_window)) {
Review Comment:
But I thought we want it return nullptr if `info[0]` is down (all options
are down)? `select` is the same as `is_down` except it checks the down window
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
