masaori335 commented on code in PR #12880:
URL: https://github.com/apache/trafficserver/pull/12880#discussion_r2814863879
##########
src/iocore/hostdb/HostDB.cc:
##########
@@ -1324,7 +1324,9 @@ HostDBRecord::select_best_http(ts_time now, ts_seconds
fail_window, sockaddr con
}
}
} else {
- best_alive = &info[0];
+ if (!info[0].is_down(now, fail_window)) {
Review Comment:
This change makes this function returning `nullptr` if `info[0]` is down.
I should use `select()` instead of `! is_down()` for consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
