bryancall opened a new pull request, #12903: URL: https://github.com/apache/trafficserver/pull/12903
Replace bare `TSAssert` in `synserver_vc_accept` and `synserver_vc_refuse` with a diagnostic `ink_abort` that logs the unexpected event number and, if the data looks like a negated errno, the `strerror` string. Rocky CI build [#8376](https://ci.trafficserver.apache.org/job/Github_Builds/job/rocky/8376/) crashed with a core dump in `synserver_vc_accept` after `SDK_API_HttpParentProxySet_Success` passed: ``` [SDK_API_HttpParentProxySet_Success] TSHttpTxnParentProxySet : [TestCase] <<PASS>> { Received expected response ID 11 } Fatal: ../src/api/InkAPITest.cc:916: failed assertion $(echo '(event == TS_EVENT_NET_ACCEPT) || (event == TS_EVENT_NET_ACCEPT_FAILED)') ``` The `TSAssert` gave no information about which event was received. The `net_accept()` code in `UnixNetAccept.cc` can send `EVENT_ERROR` with a negated errno when `accept()` fails, but without diagnostics we cannot confirm that. This change ensures the next failure logs the actual event number and errno so we can make a targeted fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
