ezelkow1 commented on code in PR #12998:
URL: https://github.com/apache/trafficserver/pull/12998#discussion_r2962700055
##########
src/iocore/net/SSLUtils.cc:
##########
@@ -1735,10 +1745,69 @@ SSLMultiCertConfigLoader::load(SSLCertLookup *lookup)
}
swoc::Errata errata(ERRATA_NOTE);
- int item_num = 0;
- for (const auto &item : parse_result.value) {
+ int num_threads = params->configLoadConcurrency;
+ if (num_threads == 0 || firstLoad) {
+ num_threads = std::thread::hardware_concurrency();
+ }
+ if (num_threads < 1) {
+ num_threads = 1;
+ }
+ num_threads = std::min(num_threads,
static_cast<int>(parse_result.value.size()));
+
Review Comment:
will add
##########
src/iocore/net/SSLUtils.cc:
##########
@@ -1735,10 +1745,69 @@ SSLMultiCertConfigLoader::load(SSLCertLookup *lookup)
}
swoc::Errata errata(ERRATA_NOTE);
- int item_num = 0;
- for (const auto &item : parse_result.value) {
+ int num_threads = params->configLoadConcurrency;
+ if (num_threads == 0 || firstLoad) {
+ num_threads = std::thread::hardware_concurrency();
+ }
Review Comment:
will add
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]