zwoop commented on code in PR #12998:
URL: https://github.com/apache/trafficserver/pull/12998#discussion_r2962938097
##########
src/iocore/net/SSLUtils.cc:
##########
@@ -1735,10 +1746,72 @@ SSLMultiCertConfigLoader::load(SSLCertLookup *lookup)
}
swoc::Errata errata(ERRATA_NOTE);
- int item_num = 0;
- for (const auto &item : parse_result.value) {
+ static constexpr int MAX_LOAD_THREADS = 256;
+
+ int num_threads = params->configLoadConcurrency;
+ if (num_threads == 0 || firstLoad) {
Review Comment:
I don't think num_threads can be 0 here, because we "clamp" it earlier.
Possibly change this to an assert, if anything ?
##########
src/records/RecordsConfig.cc:
##########
@@ -1180,6 +1180,8 @@ static constexpr RecordElement RecordsConfig[] =
{RECT_CONFIG, "proxy.config.ssl.server.multicert.filename", RECD_STRING,
ts::filename::SSL_MULTICERT, RECU_RESTART_TS, RR_NULL, RECC_NULL, nullptr,
RECA_NULL}
,
{RECT_CONFIG, "proxy.config.ssl.server.multicert.exit_on_load_fail",
RECD_INT, "1", RECU_RESTART_TS, RR_NULL, RECC_INT, "[0-1]", RECA_NULL}
+,
Review Comment:
Hmmm, why is this comma here, and not indented like above? Do we turn off
clang-format here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
