brbzull0 commented on code in PR #13075:
URL: https://github.com/apache/trafficserver/pull/13075#discussion_r3347869026
##########
tests/gold_tests/traffic_ctl/remap_inc/remap_inc.test.py:
##########
@@ -14,16 +14,12 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-import os
-
Test.Summary = '''
Test traffic_ctl config reload with remap.config .include directive
'''
Test.ContinueOnFail = False
-Test.Setup.Copy("wait_reload.sh")
Review Comment:
Good catch, removed.
##########
tests/gold_tests/tls/ssl_multicert_loader.test.py:
##########
@@ -78,19 +78,13 @@
tr2.Processes.Default.Env = ts.Env
tr2.Processes.Default.ReturnCode = 0
-tr2reload = Test.AddTestRun("Reload config")
-tr2reload.StillRunningAfter = ts
+tr2reload = Test.AddConfigReload(ts, expect="fail",
expect_tasks=["ssl_multicert.yaml"], description="Reload config")
tr2reload.StillRunningAfter = server
-tr2reload.Processes.Default.Command = 'traffic_ctl config reload'
-tr2reload.Processes.Default.Env = ts.Env
-tr2reload.Processes.Default.ReturnCode = 0
-ts.Disk.diags_log.Content = Testers.ContainsExpression('ERROR: ', 'ERROR')
Review Comment:
Yeah, on purpose. `expect="fail"` already asserts the reload exited with
code `2` via monitor mode, and `expect_tasks=["ssl_multicert.yaml"]` confirms
the right handler actually ran.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
