brbzull0 commented on code in PR #13075:
URL: https://github.com/apache/trafficserver/pull/13075#discussion_r3347878087
##########
tests/gold_tests/tls/tls_sni_yaml_reload.test.py:
##########
@@ -84,8 +84,6 @@
tr.Processes.Default.ReturnCode = 0
tr.Processes.Default.Streams.stdout = Testers.ExcludesExpression("Could Not
Connect", "Verify curl could successfully connect")
tr.Processes.Default.Streams.stderr =
Testers.IncludesExpression(f"CN={sni_domain}", f"Verify curl used the
{sni_domain} SNI")
-ts.Disk.diags_log.Content = Testers.IncludesExpression(
- "SSL negotiation finished successfully", "Verify that the TLS handshake
was successful")
Review Comment:
Yes. Now that I was re-checking this It turns out it's a dead check on
master, the string itself doesn't appear anywhere in the ATS source.
My understanding is that the successful handshake is already proven by the
`CN={sni_domain}` check on curl stderr right above.
##########
src/iocore/net/SSLClientCoordinator.cc:
##########
@@ -37,8 +37,8 @@ SSLClientCoordinator::reconfigure(ConfigContext reconf_ctx)
// The SSLConfig owns the client cert context storage and the SNIConfig will
load
// into it.
SSLConfig::reconfigure(reconf_ctx.add_dependent_ctx("SSLConfig"));
- SNIConfig::reconfigure(reconf_ctx.add_dependent_ctx("SNIConfig"));
-
SSLCertificateConfig::reconfigure(reconf_ctx.add_dependent_ctx("SSLCertificateConfig"));
+ SNIConfig::reconfigure(reconf_ctx.add_dependent_ctx("SNIConfig",
ts::filename::SNI));
+
SSLCertificateConfig::reconfigure(reconf_ctx.add_dependent_ctx("SSLCertificateConfig",
ts::filename::SSL_MULTICERT));
#if TS_USE_QUIC == 1
QUICCertConfig::reconfigure(reconf_ctx.add_dependent_ctx("QUICCertConfig"));
Review Comment:
Yes!! thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
