Copilot commented on code in PR #13289:
URL: https://github.com/apache/trafficserver/pull/13289#discussion_r3425390071
##########
src/iocore/net/SSLNetVConnection.cc:
##########
@@ -991,6 +991,7 @@ SSLNetVConnection::clear()
client_sess.reset();
if (ssl != nullptr) {
+ Metrics::Counter::increment(ssl_rsb.connections_closed);
SSL_free(ssl);
ssl = nullptr;
Review Comment:
`proxy.process.ssl.connections_closed` is incremented in `clear()` before
`SSL_free(ssl)`, but `SSLNetVConnection` also frees `this->ssl` in other code
paths (e.g. when switching to blind-tunnel mode during handshake). Those frees
won't be counted, so the new metric will under-report teardown volume relative
to the PR description ("incremented once per SSL_free"). Consider incrementing
the counter at each `SSL_free(this->ssl)` that corresponds to a connection
teardown (e.g. the tunnel conversion paths).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
