moonchen commented on code in PR #13289:
URL: https://github.com/apache/trafficserver/pull/13289#discussion_r3439560292
##########
src/iocore/net/SSLNetVConnection.cc:
##########
@@ -991,6 +991,7 @@ SSLNetVConnection::clear()
client_sess.reset();
if (ssl != nullptr) {
+ Metrics::Counter::increment(ssl_rsb.connections_closed);
SSL_free(ssl);
ssl = nullptr;
Review Comment:
`connections_closed` counts terminated TLS connections (the `clear()`
teardown path). The other two `SSL_free(this->ssl)` sites are early
blind-tunnel conversions — they free the SSL before any data is read and the
connection continues as a blind tunnel rather than being torn down, so they are
not connection closes. That blind-tunnel volume is already tracked separately
by `proxy.process.tunnel.total_client_connections_*` (per tunnel type). Updated
the PR description to say "once per TLS connection teardown" instead of "once
per SSL_free".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
