masaori335 commented on code in PR #13310:
URL: https://github.com/apache/trafficserver/pull/13310#discussion_r3456111242


##########
include/tsutil/Metrics.h:
##########
@@ -304,17 +305,17 @@ class Metrics
 
   class Storage
   {
-    BlobStorage        _blobs;
-    uint16_t           _cur_blob = 0;
-    uint16_t           _cur_off  = 0;
-    LookupTable        _lookups;
-    mutable std::mutex _mutex;
+    mutable ts::shared_mutex _mutex;

Review Comment:
   Replacing `mutex` with `shared_mutex` seems discussable. I'd like spawn this 
to another PR for performance comparison.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to