masaori335 commented on code in PR #13310:
URL: https://github.com/apache/trafficserver/pull/13310#discussion_r3463363948


##########
include/tsutil/TsSharedMutex.h:
##########
@@ -178,6 +184,38 @@ class shared_mutex
   X(std::atomic<int> _shared{0};)
 };
 
+// RAII guards for ts::shared_mutex that carry Clang thread-safety capability
+// state. Prefer these over std::unique_lock / std::shared_lock in code 
annotated
+// for -Wthread-safety: the analysis does not reliably track the std wrappers
+// (see tsutil/ts_thread_safety.h).

Review Comment:
   Sounds nice! Shorter is better!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to