JosiahWI commented on code in PR #12925:
URL: https://github.com/apache/trafficserver/pull/12925#discussion_r3552746539
##########
src/iocore/net/UnixNetAccept.cc:
##########
@@ -112,7 +112,7 @@ net_accept(NetAccept *na, void *ep, bool blockable)
if (res == -EAGAIN || res == -ECONNABORTED || res == -EPIPE) {
goto Ldone;
}
- if (na->server.sock.is_ok() && !na->action_->cancelled) {
+ if (na->action_->server.load(std::memory_order_acquire) != nullptr &&
!na->action_->cancelled) {
Review Comment:
This makes some assumptions about invariants for action cancellation.
Copilot's justification for its proposed solution is more than insufficient
given the risk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
