JosiahWI commented on code in PR #13702:
URL: https://github.com/apache/trafficserver/pull/13702#discussion_r4040201554
##########
src/iocore/net/UnixNetAccept.cc:
##########
@@ -112,7 +112,7 @@ net_accept(NetAccept *na, void *ep, bool blockable)
if (res == -EAGAIN || res == -ECONNABORTED || res == -EPIPE) {
goto Ldone;
}
- if (na->server.sock.is_ok() && !na->action_->cancelled) {
+ if (na->action_->is_listening()) {
Review Comment:
I think it's implied by the Action API that the caller MUST hold the action
mutex when cancelling. If `NetAccept::stop_accept` does not, this may be
another bug.
##########
src/iocore/net/UnixNetAccept.cc:
##########
@@ -112,7 +112,7 @@ net_accept(NetAccept *na, void *ep, bool blockable)
if (res == -EAGAIN || res == -ECONNABORTED || res == -EPIPE) {
goto Ldone;
}
- if (na->server.sock.is_ok() && !na->action_->cancelled) {
+ if (na->action_->is_listening()) {
Review Comment:
I think it's implied by the Action API that the caller MUST hold the action
mutex when cancelling. If `NetAccept::stop_accept` does not, that may be
another bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
