bneradt commented on code in PR #13342:
URL: https://github.com/apache/trafficserver/pull/13342#discussion_r3572049205
##########
src/iocore/net/P_SSLCertLookup.h:
##########
@@ -154,10 +154,18 @@ struct SSLCertLookup : public ConfigInfo {
SSLCertContext *find(const std::string &name, SSLCertContextType ctxType =
SSLCertContextType::GENERIC) const;
// Return the last-resort default TLS context if there is no name or address
match.
- SSL_CTX *
+ shared_SSL_CTX
defaultContext() const
Review Comment:
Good suggestion. I kept the existing default-context storage model in this
PR to avoid broadening the fix into an ownership refactor. Caching the wildcard
SSLCertContext and delegating to its synchronized accessors would remove the
duplicate state and is a worthwhile follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
