Copilot commented on code in PR #13342:
URL: https://github.com/apache/trafficserver/pull/13342#discussion_r3572830960
##########
tests/tools/plugins/ssl_secret_load_test.cc:
##########
@@ -159,8 +159,8 @@ CB_Update_Secret(TSCont cont, TSEvent /* event ATS_UNUSED
*/, void * /* edata AT
}
}
for (auto name : updates) {
- Dbg(dbg_ctl, "update cert for secret %s", name.c_str());
TSSslSecretUpdate(name.c_str(), name.length());
+ Dbg(dbg_ctl, "updated cert for secret %s", name.c_str());
}
Review Comment:
The log line now unconditionally says the secret was updated, but the return
code from TSSslSecretUpdate() is ignored. This makes the message (and the
AuTest synchronization that depends on it) misleading if the update fails.
Capture the TSReturnCode and only log "updated" on success (and log a failure
otherwise).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
