bneradt commented on code in PR #13342:
URL: https://github.com/apache/trafficserver/pull/13342#discussion_r3573015389


##########
tests/tools/plugins/ssl_secret_load_test.cc:
##########
@@ -159,8 +159,8 @@ CB_Update_Secret(TSCont cont, TSEvent /* event ATS_UNUSED 
*/, void * /* edata AT
     }
   }
   for (auto name : updates) {
-    Dbg(dbg_ctl, "update cert for secret %s", name.c_str());
     TSSslSecretUpdate(name.c_str(), name.length());
+    Dbg(dbg_ctl, "updated cert for secret %s", name.c_str());
   }

Review Comment:
   The plugin now checks TSSslSecretUpdate() and emits the updated cert 
synchronization marker only on success; failures are reported through TSError.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to