masaori335 commented on code in PR #13328:
URL: https://github.com/apache/trafficserver/pull/13328#discussion_r3575994635
##########
src/iocore/cache/CacheDir.cc:
##########
@@ -947,6 +948,11 @@ sync_cache_dir_on_shutdown()
thr.join();
}
+ // All writers are now stopped (every stripe's mutex was held and released
by the
+ // shutdown threads above), so the directory is final -- only now is it safe
to
+ // mark the shm control segment clean.
+ CacheShm::mark_clean_shutdown();
Review Comment:
That's true, this comment is wrong. The intention is set the "clean flag" to
indicate next process that previous process did not crash (did shutdown) and
cache dir on shm is available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
