masaori335 commented on code in PR #13328:
URL: https://github.com/apache/trafficserver/pull/13328#discussion_r3576008291
##########
src/iocore/cache/StripeSM.cc:
##########
@@ -1342,7 +1366,15 @@ StripeSM::shutdown(EThread *shutdown_thread)
// directories have not been inserted for these writes
if (!this->_write_buffer.is_empty()) {
Dbg(dbg_ctl_cache_dir_sync, "Dir %s: flushing agg buffer first",
this->hash_text.get());
- this->flush_aggregate_write_buffer(this->fd);
+ if (!this->flush_aggregate_write_buffer(this->fd)) {
Review Comment:
Good point. When double write (flush agg bufer + in-flight AIO) happens,
`write_pos` is advanced twice. So next process will start writing from there.
This is wasting disk space. Let me figure out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
