Copilot commented on code in PR #13423:
URL: https://github.com/apache/trafficserver/pull/13423#discussion_r3640769925
##########
CMakePresets.json:
##########
@@ -185,10 +185,12 @@
"inherits": ["ci"],
"cacheVariables": {
"ENABLE_PROBES": "ON",
- "OPENSSL_ROOT_DIR": "/opt/openssl-quic",
+ "OPENSSL_ROOT_DIR": "/usr",
"opentelemetry_ROOT": "/opt",
- "CURL_ROOT": "/opt",
+ "CURL_ROOT": "/usr",
"wamr_ROOT": "/opt",
+ "ENABLE_OTEL_TRACER": "ON",
+ "ENABLE_WASM_WAMR": "ON",
Review Comment:
The Fedora CI presets set cache variables `ENABLE_OTEL_TRACER` and
`ENABLE_WASM_WAMR`, but the build system keys off `BUILD_OTEL_TRACER` and
`BUILD_WASM_WAMR` (see cmake/ExperimentalPlugins.cmake and
plugins/experimental/CMakeLists.txt). As-is, these lines won't actually force
the OTEL tracer or WAMR WASM plugin to be built, so CI can still silently omit
them.
This issue also appears on line 217 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
