bneradt commented on code in PR #13423:
URL: https://github.com/apache/trafficserver/pull/13423#discussion_r3641011347


##########
CMakePresets.json:
##########
@@ -185,10 +185,12 @@
       "inherits": ["ci"],
       "cacheVariables": {
         "ENABLE_PROBES": "ON",
-        "OPENSSL_ROOT_DIR": "/opt/openssl-quic",
+        "OPENSSL_ROOT_DIR": "/usr",
         "opentelemetry_ROOT": "/opt",
-        "CURL_ROOT": "/opt",
+        "CURL_ROOT": "/usr",
         "wamr_ROOT": "/opt",
+        "ENABLE_OTEL_TRACER": "ON",
+        "ENABLE_WASM_WAMR": "ON",

Review Comment:
   ENABLE_OTEL_TRACER and ENABLE_WASM_WAMR are the correct cache options. 
auto_option() creates ENABLE_<feature> and derives the corresponding 
BUILD_<feature> variable after checking its dependencies. With these options 
set to ON, configuration fails if a dependency is unavailable. I also verified 
that both Fedora presets report the derived BUILD_* variables as true and 
successfully build both plugin targets.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to