Copilot commented on code in PR #13439: URL: https://github.com/apache/trafficserver/pull/13439#discussion_r3683259345
########## src/iocore/eventsystem/unit_tests/test_Lock.cc: ########## @@ -0,0 +1,349 @@ +/** @file + + Catch2 unit tests for the Lock.h mutex acquisition macros. + + @section license License + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + */ + +#include "inkevent_test_fixtures.h" + +using inkevent_test::AtomicFlag; +using inkevent_test::EventProcessorListener; + +CATCH_REGISTER_LISTENER(EventProcessorListener) + +namespace +{ + +class HoldOnEThread : public Continuation +{ +public: + HoldOnEThread(ProxyMutex *self_mutex, Ptr<ProxyMutex> &target) : Continuation(self_mutex), target_mutex(target) + { + SET_HANDLER(&HoldOnEThread::on_event); + } + + Ptr<ProxyMutex> target_mutex; + AtomicFlag held; + AtomicFlag release; + AtomicFlag done; + +private: + int + on_event(int /* event ATS_UNUSED */, void * /* data ATS_UNUSED */) + { + SCOPED_MUTEX_LOCK(guard, target_mutex, this_ethread()); + held.set(); + release.wait_until_set(); + done.set(); + return 0; Review Comment: `done` is signaled while the `SCOPED_MUTEX_LOCK` guard is still in scope, meaning the mutex may still be held when other threads observe `done`. This can make the multithreaded tests flaky (e.g., a `MUTEX_TRY_LOCK` immediately after `done` may still fail). Move `done.set()` to after the guard is destroyed (e.g., wrap the lock section in an inner scope and signal `done` after that scope), or explicitly release the guard before setting `done`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
