Copilot commented on code in PR #13439: URL: https://github.com/apache/trafficserver/pull/13439#discussion_r3713904421
########## src/iocore/eventsystem/unit_tests/test_Lock.cc: ########## @@ -0,0 +1,388 @@ +/** @file + + Catch2 unit tests for the Lock.h mutex acquisition macros. + + @section license License + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + */ + +#define CATCH_CONFIG_THREAD_SAFE_ASSERTIONS +#include "inkevent_test_fixtures.h" + +#include <tscore/ink_assert.h> + +using inkevent_test::AtomicFlag; +using inkevent_test::EventProcessorListener; + +CATCH_REGISTER_LISTENER(EventProcessorListener) + +namespace +{ + +class HoldOnEThread : public Continuation +{ +public: + HoldOnEThread(ProxyMutex *self_mutex, Ptr<ProxyMutex> &target) : Continuation(self_mutex), target_mutex(target) + { + SET_HANDLER(&HoldOnEThread::on_event); + this->callback_action = eventProcessor.schedule_imm(this, ET_CALL); + ink_assert(this->callback_action != nullptr); + } Review Comment: `eventProcessor.schedule_imm()` may return a sentinel `Action*` (e.g. `ACTION_RESULT_DONE`) rather than a real pointer. This class later dereferences `callback_action` (e.g. `callback_action->cancelled`), which would be undefined behavior/crash for sentinel values (low bit set). Handle sentinel returns explicitly (check `(uintptr_t)callback_action & 1`): if a sentinel is returned, treat the callback as already completed (set the appropriate flags) and avoid storing/dereferencing it as an `Action*`. ########## src/iocore/eventsystem/unit_tests/test_Lock.cc: ########## @@ -0,0 +1,388 @@ +/** @file + + Catch2 unit tests for the Lock.h mutex acquisition macros. + + @section license License + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + */ + +#define CATCH_CONFIG_THREAD_SAFE_ASSERTIONS +#include "inkevent_test_fixtures.h" + +#include <tscore/ink_assert.h> + +using inkevent_test::AtomicFlag; +using inkevent_test::EventProcessorListener; + +CATCH_REGISTER_LISTENER(EventProcessorListener) + +namespace +{ + +class HoldOnEThread : public Continuation +{ +public: + HoldOnEThread(ProxyMutex *self_mutex, Ptr<ProxyMutex> &target) : Continuation(self_mutex), target_mutex(target) + { + SET_HANDLER(&HoldOnEThread::on_event); + this->callback_action = eventProcessor.schedule_imm(this, ET_CALL); + ink_assert(this->callback_action != nullptr); + } + + // In case of an exception in a thread that would have set release, we set + // it here in order to unfreeze any threads that may be waiting on done. + ~HoldOnEThread() + { + this->release.set(); + this->cancel_callback(); + this->done.wait_until_set(); + } Review Comment: The destructor can block forever. `on_event()` only sets `done` when `release.wait_until_set()` succeeds, and the comment explicitly notes the wait can time out; in that case `done` is never set. If the callback has already started (`held` set) and then timed out, `cancel_callback()` won’t cancel (because `is_expecting_callback()` returns false once `held` is set), leaving `done` unset and the destructor waiting indefinitely. Make `done` guaranteed to be set on all callback exit paths (including timeout), or change the destructor to avoid an unbounded wait (e.g., timed wait + fallback/cleanup). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
