bneradt commented on code in PR #13186:
URL: https://github.com/apache/trafficserver/pull/13186#discussion_r3684724454
##########
src/iocore/net/UnixUDPNet.cc:
##########
@@ -666,14 +666,16 @@
UDPNetProcessorInternal::read_multiple_messages_from_net(UDPNetHandler *nh, UDPC
nh->udp_callbacks.enqueue(uc);
uc->onCallbackQueue = 1;
}
+
+ return return_val == static_cast<int>(MAX_RECEIVE_MSG_PER_CALL);
}
#endif
void
UDPNetProcessorInternal::udp_read_from_net(UDPNetHandler *nh, UDPConnection
*xuc)
{
#if HAVE_RECVMMSG
- read_multiple_messages_from_net(nh, xuc);
+ while (read_multiple_messages_from_net(nh, xuc)) {}
#else
Review Comment:
Fixed in #13213 before it landed. udp_read_from_net() now limits each event
to MAX_RECEIVE_MSG_BATCHES_PER_EVENT—currently eight batches—so the net thread
cannot drain indefinitely. UnixUDPNet.cc is no longer changed by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
