bneradt commented on code in PR #13186: URL: https://github.com/apache/trafficserver/pull/13186#discussion_r3685523729
########## src/iocore/net/quic/QUICConfig.cc: ########## @@ -54,6 +57,24 @@ quic_new_ssl_ctx() return ssl_ctx; } +SSL_CTX * +quic_new_server_ssl_ctx() Review Comment: quic_new_ssl_ctx() cannot unconditionally use OSSL_QUIC_server_method() because it is also called by quic_init_client_ssl_ctx(). Native OpenSSL requires the server-specific method for the listener, while the client and non-native quiche paths must retain the existing TLS_method() context, so moving the #ifdef into the shared function would make that function return a server-only context to client callers in native builds. Keeping quic_new_server_ssl_ctx() makes the role distinction explicit; its non-native path delegates to quic_new_ssl_ctx(), and the duplicated TLS-version settings noted separately have now been removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
