maskit commented on PR #13440: URL: https://github.com/apache/trafficserver/pull/13440#issuecomment-5137573106
We deal with a similar const-ness difference at another place. `const_cast` is acceptable. https://github.com/apache/trafficserver/blob/3df2bceb04b4c022aaf5bef67d9986c90fa81fbe/src/iocore/net/OCSPStapling.cc#L370-L371 FYI: `X509_NAME_get_index_by_NID`: | Version | Signature | | ------------------------------ | ------------------------------------------------------------------------------ | | OpenSSL 1.1.1 | `int X509_NAME_get_index_by_NID(X509_NAME *name, int nid, int lastpos);` | | OpenSSL 3.0 | `int X509_NAME_get_index_by_NID(const X509_NAME *name, int nid, int lastpos);` | | OpenSSL master (post-constify) | `int X509_NAME_get_index_by_NID(const X509_NAME *name, int nid, int lastpos);` | | BoringSSL (current) | `int X509_NAME_get_index_by_NID(const X509_NAME *name, int nid, int lastpos);` | `X509_get_subject_name`: | Version | Signature | | ------------------------------ | -------------------------------------------------------- | | OpenSSL 1.1.1 | `X509_NAME *X509_get_subject_name(const X509 *a);` | | OpenSSL 3.0 | `X509_NAME *X509_get_subject_name(const X509 *a);` | | OpenSSL master (post-constify) | `const X509_NAME *X509_get_subject_name(const X509 *a);` | | BoringSSL | `X509_NAME *X509_get_subject_name(const X509 *x509);` | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
