maskit opened a new pull request, #13476:
URL: https://github.com/apache/trafficserver/pull/13476
## Summary
Continues #13440 ("Resolve OpenSSL 4.0 build issues"), fixing the remaining
CI failures on Ubuntu 20.04 and FreeBSD 13.1 (OpenSSL 1.1.1) flagged in review.
`X509_NAME_get_index_by_NID()` takes a non-const `X509_NAME *` on OpenSSL
1.1.1 but a `const X509_NAME *` on OpenSSL 3.0+ and post-constify
OpenSSL/BoringSSL. The original PR widened several `X509_NAME`-typed variables
to `const` to build against the newer, constified signature, which broke the
older signature at three call sites:
- `src/tscore/X509HostnameValidator.cc` — `validate_hostname()`
- `src/iocore/net/SSLUtils.cc` —
`SSLMultiCertConfigLoader::load_certs_and_cross_reference_names()`
- `plugins/experimental/txn_box/plugin/src/ts_util.cc` — `ssl_value_for()`
Each call site now does `const_cast<X509_NAME *>(...)`, matching the
existing precedent in `OCSPStapling.cc` for the same kind of OpenSSL-version
const mismatch.
## Test plan
- [x] Built `tscore`, `inknet`, and `txn_box` targets locally against
BoringSSL — all compile clean
- [x] Ran `cmake --build build -t format` — no additional changes
- [ ] CI to confirm the Ubuntu 20.04 / FreeBSD 13.1 (OpenSSL 1.1.1) jobs
that failed on #13440 now pass
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
