Copilot commented on code in PR #13478: URL: https://github.com/apache/trafficserver/pull/13478#discussion_r3706602227
########## src/iocore/net/P_QUICNetVConnection.h: ########## @@ -240,10 +242,12 @@ class QUICNetVConnection : public UnixNetVConnection, void _close_packet_write_ready(Event *data); Event *_packet_write_ready = nullptr; - void _schedule_quiche_timeout(); - void _unschedule_quiche_timeout(); - void _close_quiche_timeout(Event *data); + void _schedule_quiche_timeout(); + void _unschedule_quiche_timeout(); + void _close_quiche_timeout(Event *data); +#if TS_HAS_QUICHE Event *_quiche_timeout = nullptr; +#endif Review Comment: The quiche-timeout methods are unconditionally declared while the state they likely operate on (`_quiche_timeout`) is now quiche-only. To keep the class interface consistent across build modes (and prevent accidental use or future build breaks if these methods reference `_quiche_timeout` in inline code), consider guarding these method declarations with `#if TS_HAS_QUICHE` as well, or providing no-op/alternate implementations when `TS_HAS_QUICHE` is disabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
