bneradt commented on code in PR #13478: URL: https://github.com/apache/trafficserver/pull/13478#discussion_r3706639858
########## src/iocore/net/P_QUICNetVConnection.h: ########## @@ -240,10 +242,12 @@ class QUICNetVConnection : public UnixNetVConnection, void _close_packet_write_ready(Event *data); Event *_packet_write_ready = nullptr; - void _schedule_quiche_timeout(); - void _unschedule_quiche_timeout(); - void _close_quiche_timeout(Event *data); + void _schedule_quiche_timeout(); + void _unschedule_quiche_timeout(); + void _close_quiche_timeout(Event *data); +#if TS_HAS_QUICHE Event *_quiche_timeout = nullptr; +#endif Review Comment: These are private backend hooks rather than part of a shared external interface. The OpenSSL implementation already supplies explicit no-op definitions for all three methods, while CMake selects only one of the OpenSSL or quiche implementation files. Guarding the declarations would therefore also require removing those definitions and would not address an active correctness or warning issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
