moonchen opened a new pull request, #13510: URL: https://github.com/apache/trafficserver/pull/13510
The rate_limit YAML parser reads `max_age` with an underscore, in three places: * the `queue` node — `plugins/experimental/rate_limit/limiter.h` * the `ip-rep` node — `plugins/experimental/rate_limit/ip_reputation.cc` * the `perma-block` sub-node — same file Every mention in the documentation spelled it `max-age`, including all three worked examples. A configuration copied from the docs therefore left `_max_age` at its default of `0` in each case, which silently disables queue expiry (the expiry pass in `sni_queue_cont()` is gated on `max_age() > std::chrono::milliseconds::zero()`) and both IP-reputation aging paths. This changes the documentation rather than the parser, so that configurations which are inert today stay inert on upgrade instead of suddenly beginning to expire queue entries or age out LRU entries with whatever value the operator wrote. The `--maxage` pparam description also referred to a ``max-age`` that matches neither the option name nor the YAML key, so it now just says "maximum age". `max-age` was the only key in the documentation that did not match the parser; `ip-rep` and `perma-block` really are hyphenated in the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
