moonchen commented on PR #13510: URL: https://github.com/apache/trafficserver/pull/13510#issuecomment-5242764286
@JosiahWI Added — there is now a note under the `max_age` option: > Note that this option was incorrectly documented as ``max-age`` with a hyphen in previous > versions. The code ignores ``max-age`` in all versions of this plugin. We have chosen > to keep the behavior the same and update the documentation, so that previously inert > configurations don't activate unexpectedly with an upgrade. Both halves of that are checkable in history, for the record. `max-age` has never been read as a configuration key — the only occurrences in `rate_limit.cc` are a debug log label, `"...max-age=%ldms..."`. And the two units have differed by a factor of 1000 since the YAML configuration arrived in #10559: that commit read `max_age` as `std::chrono::seconds` into a `std::chrono::milliseconds` member, while `--maxage` was already raw milliseconds. That is why the units are documented as they behave rather than made consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
