moonchen commented on PR #13352: URL: https://github.com/apache/trafficserver/pull/13352#issuecomment-5219505267
> since validation behavior changes, does this need a doc update? Yes, added. There is now a paragraph after the parameter reference in `doc/admin-guide/plugins/prefetch.en.rst` stating that an invalid parameter value is a configuration error: `--fetch-count` and `--fetch-max` must be decimal numbers that fit in an unsigned integer, `--fetch-overflow` must be `32` or `64`, and `--fetch-path-pattern` must compile and may only reference capture groups the pattern defines. It also says the remap rule fails to load rather than loading with prefetch silently disabled, and that `traffic_ctl config reload` rejects such a configuration and keeps the running one. Rebased onto master while here, which picked up #71d40c137c (`Constrain prefetch relative paths`). That reworks the `--fetch-query` relative-path branch, so it does not overlap the `--fetch-path-pattern` branch this PR touches. All nine prefetch autests pass locally, including the `prefetch_query_path_traversal` test that came with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
