moonchen commented on PR #13352: URL: https://github.com/apache/trafficserver/pull/13352#issuecomment-5242654492
Holding this until #13517 merges. As it stands here, `replace()` still takes the `matches[replIndex]` branch for a non-participating group, which returns a null `data()` since #13441 landed. #13517 fixes that in `RegexMatches::operator[]` itself, after which this collapses to a plain `matches[replIndex]` with no guard needed. Rebasing once it's in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
