serrislew commented on code in PR #13514: URL: https://github.com/apache/trafficserver/pull/13514#discussion_r3761414343
########## src/proxy/http/Http1ClientSession.cc: ########## @@ -207,7 +207,6 @@ Http1ClientSession::new_connection(NetVConnection *new_vc, MIOBuffer *iobuf, IOB _reader = reader ? reader : read_buffer->alloc_reader(); trans.set_reader(_reader); - trans.upstream_outbound_options = *accept_options; Review Comment: this copied the optoins while still inside `accept()` so it didn't matter that the acceptor didn't outlive it. but now that the copy is deferred to `ProxyTransaction::new_transaction` doesn't that break https://github.com/apache/trafficserver/blob/master/src/traffic_server/SocksProxy.cc#L560 since `HttpSessionAccept` is stack local so it is gone before he transaction reads accept options? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
