bneradt commented on code in PR #13514: URL: https://github.com/apache/trafficserver/pull/13514#discussion_r3857341371
########## src/proxy/http/Http1ClientSession.cc: ########## @@ -207,7 +207,6 @@ Http1ClientSession::new_connection(NetVConnection *new_vc, MIOBuffer *iobuf, IOB _reader = reader ? reader : read_buffer->alloc_reader(); trans.set_reader(_reader); - trans.upstream_outbound_options = *accept_options; Review Comment: Good catch—this was a real lifetime issue. I moved the SOCKS HTTP acceptor onto the long-lived `SocksAccepter`, so sessions handed off from SOCKS no longer retain a pointer to a stack-local acceptor. Fixed in ae3c6f1e04. Validation in `asfats5`: - unit-test-enabled CI Fedora build and install - `test_http`: 18 test cases, 576 assertions - AuTests: `remap_http`, `h2enable`, and `h3_proxy_verifier` (3/3 passed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
