bneradt commented on code in PR #13586: URL: https://github.com/apache/trafficserver/pull/13586#discussion_r3859449346
########## tests/gold_tests/pluginTest/abuse_shield/h2_rate_client.py: ########## @@ -0,0 +1,288 @@ +#!/usr/bin/env python3 +""" +An HTTP/2 client that sends requests at a configurable rate. + +This client is designed for testing rate limiting functionality in the +abuse_shield plugin. It sends a specified number of requests at a controlled +rate over a single HTTP/2 connection. +""" +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +import argparse +import logging +import socket +import ssl +import sys +import time +from typing import Dict, Optional, Tuple Review Comment: Fixed. `receive_responses()` now imports and uses `select` to wait up to the requested timeout before draining available data, and it restores the socket’s prior timeout afterward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
