bneradt commented on PR #13586: URL: https://github.com/apache/trafficserver/pull/13586#issuecomment-5429046181
Thanks for the thorough review. I addressed the observations in `b41be77d0a`. Rate state is now independent per rule and updated using a packed atomic CAS; connection enforcement runs at TLS VCONN start and plain HTTP session start; connection rules are evaluated immediately; block state is stored separately and token debt prevents eviction. Action metrics now distinguish successful and failed effects, configuration parsing fails closed, reload preserves runtime enablement and rejects startup-only setting changes, and UdiTable is private to the plugin. I also removed hot-path table-stat synchronization, moved dump formatting outside the table lock, restored JAx diagnostics, added exception barriers/direct includes, and corrected the H2 error handling. The AuTest coverage now exercises actual block enforcement, H2 RST_STREAM errors, trusted bypass, rejected reload retention, plain HTTP connection limiting, connect-and-idle TLS clients, lenient-first rules, and serial execution. Normal, ASan/ODR, AuTest, formatting, and documentation builds pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
