sinhaparth5 commented on code in PR #13600: URL: https://github.com/apache/trafficserver/pull/13600#discussion_r3895769572
########## plugins/experimental/rate_limit/sni_selector.cc: ########## @@ -27,22 +27,29 @@ std::atomic<SniSelector *> SniSelector::_instance = nullptr; /////////////////////////////////////////////////////////////////////////////// // YAML parser for the global YAML configuration (via plugin.config) // +// This is the exception boundary for the configuration parsing. The node +// accessors and conversions in parseYamlFile() throw on malformed input, and +// this runs on the management update continuation during a config reload, so Review Comment: Reworded in ae9257ba2 to "a config reload runs this on an ET_TASK thread via `ConfigUpdateCallback`". That points at the right place, and it explains why the reload reported success before the process died. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
