Copilot commented on code in PR #13556:
URL: https://github.com/apache/trafficserver/pull/13556#discussion_r3909170164
##########
tests/gold_tests/pluginTest/lua/lua_global_shutdown.test.py:
##########
@@ -25,40 +28,172 @@
Test.ContinueOnFail = True
+# Helper script for signaling a traffic_server process by command-line
identifier
+# match. Reused from gold_tests/logging.
+TS_PID_SCRIPT = 'ts_process_handler.py'
+
server = Test.MakeOriginServer("server")
-ts = Test.MakeATSProcess("ts")
+
+# The identifier shutdown_race_client.py matches on to find this process.
+ts = Test.MakeATSProcess("lua_shutdown_ts")
Review Comment:
The comment says the identifier is `shutdown_race_client.py`, but the helper
script is passed `lua_shutdown_ts` (the ATS process name/identifier). This
mismatch can confuse future maintenance/debugging of the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
