bneradt commented on PR #13556: URL: https://github.com/apache/trafficserver/pull/13556#issuecomment-5736923503
Yes—the case this barrier protects is a native/FFI resource shared by global and remap scripts. If a global `__shutdown__` releases that resource while a remap callback still uses it, locking only the global states leaves the same use-after-free window. `__clean__` is appropriate for remap-instance-owned resources, but cannot protect a shared resource released by the global shutdown callback. This coverage applies when `proxy.config.plugin.dynamic_reload_mode=0`, so the global and remap instances use the same plugin image. With dynamic reload enabled, the private remap copies have separate state arrays that this barrier cannot reach; the documentation already cautions against releasing resources shared across those copies from `__shutdown__`. I have clarified the shared-resource rationale and that queued callbacks remain blocked until process exit, even after the shutdown functions return. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
