Copilot commented on code in PR #13621:
URL: https://github.com/apache/trafficserver/pull/13621#discussion_r3919663813


##########
src/proxy/http3/test/test_QPACK.cc:
##########
@@ -22,10 +22,12 @@
  */
 
 #include <catch2/catch_test_macros.hpp>
+#include <chrono>
 #include <cstdio>
 #include <cstdlib>
 #include <fstream>
 #include <iostream>
+#include <thread>

Review Comment:
   If you switch the event flag to `std::atomic` (to fix the cross-thread 
polling data race), add an explicit `<atomic>` include instead of relying on 
transitive includes from Catch2/other headers.
   
   This issue also appears on line 100 of the same file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to