bneradt commented on code in PR #13621: URL: https://github.com/apache/trafficserver/pull/13621#discussion_r3937043198
########## src/proxy/http3/test/test_QPACK.cc: ########## @@ -22,10 +22,12 @@ */ #include <catch2/catch_test_macros.hpp> +#include <chrono> #include <cstdio> #include <cstdlib> #include <fstream> #include <iostream> +#include <thread> Review Comment: Applied. `_event` is a `std::atomic<int>` now, with an explicit `<atomic>` include rather than relying on a transitive one, and `last_event()` is `const`. The write happens on the ET_NET thread running the QPACK callback while the read happens on the thread running the test, so the plain `int` was a race under the old `sleep(1)` too — polling just made it obvious. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
