maskit commented on code in PR #13636:
URL: https://github.com/apache/trafficserver/pull/13636#discussion_r3960047257
##########
src/proxy/http3/QPACK.cc:
##########
@@ -804,9 +804,15 @@ QPACK::_decode_literal_header_field_without_name_ref(const
uint8_t *buf, size_t
}
read_len += ret;
- char *value;
+ char *value = nullptr;
uint64_t value_len;
if ((ret = xpack_decode_string(this->_arena, &value, value_len, buf +
read_len, buf + buf_len, _header_field_max_size, 7)) < 0) {
+ // xpack_decode_string may allocate before returning failure (Huffman
Review Comment:
It looks like HPACK has the same issue. We may want to change
xpack_decode_string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
