brbzull0 commented on code in PR #13636:
URL: https://github.com/apache/trafficserver/pull/13636#discussion_r3969481980
##########
src/proxy/http3/QPACK.cc:
##########
@@ -818,8 +819,9 @@ QPACK::_decode_literal_header_field_without_name_ref(const
uint8_t *buf, size_t
QPACKDebug("Decoded Literal Header Field Without Name Ref: name=%.*s,
value=%.*s", static_cast<uint16_t>(name_len), name,
static_cast<uint16_t>(value_len), value);
- this->_arena.str_free(name);
+ // Free in reverse allocation order so Arena rewinds both entries.
Review Comment:
Fixed, both occurrences now read "so Arena can rewind both entries".
The description covers why the stronger claim does not hold: `Arena::free()`
walks the block list with `while (b->next)`, so it never inspects the last
block, and on a single-block arena the free is a no-op.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
