cmcfarlen commented on code in PR #13658:
URL: https://github.com/apache/trafficserver/pull/13658#discussion_r3973703534
##########
src/iocore/net/CMakeLists.txt:
##########
@@ -222,12 +222,12 @@ if(BUILD_TESTING)
endif()
set(LIBINKNET_UNIT_TEST_DIR "${CMAKE_SOURCE_DIR}/src/iocore/net/unit_tests")
target_compile_definitions(test_net PRIVATE
LIBINKNET_UNIT_TEST_DIR=${LIBINKNET_UNIT_TEST_DIR})
- add_catch2_test(NAME test_net COMMAND test_net)
-
- if(NOT APPLE)
+ if(APPLE)
+ add_catch2_test(NAME test_net COMMAND test_net)
+ else()
# Disable ORD violation caused by double definition inside a stub file
libinknet_stub.cc
Review Comment:
Fixed in 0993e1446d. It was the last remaining one — the other three
occurrences already said ODR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
