moonchen commented on code in PR #13667:
URL: https://github.com/apache/trafficserver/pull/13667#discussion_r3993537088
##########
include/iocore/net/NetVConnection.h:
##########
@@ -381,6 +382,21 @@ class NetVConnection : public VConnection, public
PluginUserArgs<TS_USER_ARGS_VC
/** Set the MPTCP state for this connection */
virtual void set_mptcp_state() = 0;
+ /** Read @c TCP_INFO from the underlying socket.
+ *
+ * @param info Filled in only when this returns @c true.
Review Comment:
Fixed in d39eebe264: the output parameter is documented as `@param[out]
info`.
##########
src/proxy/http/HttpSM.cc:
##########
@@ -5650,6 +5663,9 @@ HttpSM::open_prewarmed_connection()
void
HttpSM::do_http_server_open(bool raw, bool only_direct)
{
+ // A failed new attempt must not report a previous origin's TCP_INFO.
+ server_tcp_info.reset();
Review Comment:
Fixed in d39eebe264. `redirect_request()` now clears the snapshot after the
redirect response has been logged. Added a replay case that primes the target
in cache, follows an origin 302, and verifies that the redirect response logs
real TCP_INFO values while the final cache hit logs `-1` for all four fields.
The test reproduced the stale values before the fix and passes with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
