moonchen commented on PR #13667: URL: https://github.com/apache/trafficserver/pull/13667#issuecomment-5640900165
Addressed the remaining Copilot feedback in 909ee65539: - Added a probe for `tcpi_snd_rexmitpack` and use that result to guard the FreeBSD accessor. - Skip non-stream sockets before `getsockopt(TCP_INFO)`. A regression test verifies that a UDP socket causes no TCP_INFO syscall. - Moved the record documentation into Logging Configuration. - Keeping AuTest Linux-only. I cannot validate a native FreeBSD run locally, so I am not adding an untested FreeBSD test path. I am keeping the accessor without per-field offset/length checks. All four Linux fields are already present in [Linux 2.6.12](https://github.com/torvalds/linux/blob/v2.6.12/include/linux/tcp.h#L140-L180). The FreeBSD member is now explicitly probed. This assumes the runtime kernel supplies those established fields; zero-initialization remains as a defensive measure. The Linux build, UDP and LogAccess unit tests, origin TCP_INFO AuTest, and Sphinx build passed. The new CMake probe was also checked on Linux against the published FreeBSD 14.3 header, with a negative fixture omitting the member. Native FreeBSD execution remains unverified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
