traeak commented on code in PR #13700: URL: https://github.com/apache/trafficserver/pull/13700#discussion_r4041411618
########## src/proxy/hdrs/URL.cc: ########## @@ -1711,6 +1711,11 @@ url_describe(HdrHeapObjImpl *raw, bool /* recurse ATS_UNUSED */) // fast path for CryptoHash, HTTP, no user/password/params/query, // no buffer overflow, no unescaping needed +// +// NOTE: this emits the ";" path/params separator, which matches +// url_CryptoHash_get_general_92() but not url_CryptoHash_get_general(). It is +// currently unreachable because url_hash_method is 0; enabling it would make +// canonical keys collide with 9.2 keys. Review Comment: documented -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
