masaori335 commented on PR #13700: URL: https://github.com/apache/trafficserver/pull/13700#issuecomment-5722303957
Timeline from the history: | Commit | What it did to the `;` | |---|---| | pre-10 | `url_CryptoHash_get_general` hashed `path + ";" + params`; `url_CryptoHash_get_fast` hardcoded `*p++ = ';'` and guarded on `m_len_params == 0`. **Both agreed** — the fast path was the canonical fast path. | | `5eb87bc8f2` (2024-07, "Deprecate the support for URL param segment") | Dropped the separator from the *general* hasher (`strs[9]` `";"` → `""`) and dropped `m_len_params` from the fast-path guard — but left `*p++ = ';'` in `url_CryptoHash_get_fast`. From here the fast path reproduces only the **9.2** byte sequence. | | `8fbd40122f` (2025-06, "Try both old(9.2) and new cache key generation") | Added `url_CryptoHash_get_92`, which reused that same (now 9.2-shaped) fast path — correct for its caller, still wrong for the canonical one. | | `cf3d8e0120` (2026-09, this PR) | Renamed it `_fast_92`, reachable only from `_get_92`; canonical always goes through `_general`. `general_92` also stops emitting the separator when the path already carries one (`has_path_params()`). | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
